Turkish Language Support (urgent)

gorkem · January 2, 2024, 2:55pm

I forked this repository to my own github (@gorkemkose)
[GitHub - Web3Auth/web3auth-locales ](GitHub - Web3Auth/web3auth-locales

Created a turkish-localization branch, push the changes there. But I couldn’t make a pull request from the original repo since the branch that I created wasn’t there. I make a pull request from my forked repo and it says the changes will be reviewed my maintainers.

I make changes specially in these two folders:

Can you review the changes or support if I did anything missing? Thanks

shahbaz · January 3, 2024, 4:21am

Hey @gorkem

Thanks for making this PR.

Please add the changes to these files, too:

https://github.com/Web3Auth/web3auth-locales/tree/main/Auth-service-locale

Let me know when you’re done updating the Auth-services so that we can start the review and testing process.

gorkem · January 3, 2024, 8:40am

Hey @shahbaz

I’ll push it today. I’m using Plug-and-Play, Web, No-modal SDK. Do I need to add changes to any other file?

Thanks

shahbaz · January 3, 2024, 10:48am

Hey @gorkem

Yes, you’ll need to add translations to these files https://github.com/Web3Auth/web3auth-locales/tree/main/Auth-service-locale

gorkem · January 3, 2024, 2:05pm

Hi @shahbaz

They are added, I submit the pull request. Can you review and approve whenever possible?

Thanks for the support!

shahbaz · January 4, 2024, 4:39am

Thank you for adding the remaining translations. We will review and test them, and if any issues arise, we will comment on the PR.

gorkem · January 4, 2024, 8:47am

Thanks @shahbaz

I saw you approved the pull request. How will I be able to use the Turkish language in my plug and play, web no-modal SDK? Can you guide me?

Thanks in advance

shahbaz · January 4, 2024, 9:47am

Hey @gorkem, we are currently working on adding this feature to all relevant packages. You can expect a release by early next week. To use this feature, simply change the ‘defaultLanguage’ parameter to ‘tr’.

shahbaz · January 5, 2024, 5:42am

Hey @gorkem, this is a preview of how it will look on Modal. Please review and let me know if everything is correct.

See the progress on this PR.

gorkem · January 5, 2024, 7:37am

Hey @shahbaz

Looks good! Thanks!!!

system · January 10, 2024, 1:01am

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.

shahbaz · January 18, 2024, 4:55pm

Hey @gorkem

Turkish language support is live with v7.3.1 of @web3auth/modal & @web3auth/no-modal.